mattermost/mattermost

Avoid passing global state into telemetry_actions.jsx in mattermost webapp

Open

#21.351 aberto em 11 de out. de 2022

Ver no GitHub
 (2 comments) (0 reactions) (1 assignee)TypeScript (32.880 stars) (7.823 forks)batch import
Difficulty/1:EasyHacktoberfestHelp WantedTech/ReactJS

Description

Description

This ticket is regarding the way we handle state actions in webapp. Similar to the util functions, we are passing the state and dispatch directly from our imported global store in the action creators.

In order to make the action creators more predictable and improve their testability we need to refactor the way we handle action creators and make sure they are always passed to mapDispatchToProps in the connected components.

Files: telemetry_actions.jsx

Proposed change in post_actions.jsx:

// get the state from getState
  ......
  dispatch({
            type: SearchTypes.RECEIVED*SEARCH*POSTS,
            data: {posts, order: newResults},
        });
} 

and then we call it dispatch(addPostToSearchResults(postId));

NOTE: Calling getState is fine as long as it's coming from thunk inside the component. We don't want to import it from stores/redux_store

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-47446

Guia do colaborador

Pilha de tecnologia
javascriptreacttypescript
Domain
frontend
Tipo Issue
refactor
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
3
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
1-3 hours
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
stale
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
clear
Prerequisites
Redux thunksReact Redux
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
65
Direção de pesquisa
Start by examining the files `telemetry actions.jsx` and `post actions.jsx` in the Mattermost webapp repository. Understand how the current action creators import global state from `stores/redux store`. Then refactor these action creators to accept `dispatch` and `getState` from thunk as shown in the example for `addPostToSearchResults`. Ensure that all calls to these actions are passed via `mapDispatchToProps` in connected components. The JIRA ticket may have additional context.