mattermost-community/focalboard

Colors in Board Groups are too bright

Open

#5.001 aberto em 18 de out. de 2023

Ver no GitHub
 (5 comments) (0 reactions) (0 assignees)TypeScript (26.187 stars) (2.542 forks)user submission
HacktoberfestHelp WantedUp for grabs

Description

Summary

Custom theme used:

{
  "awayIndicator": "#eea941",
  "buttonBg": "#43b581",
  "buttonColor": "#ffffff",
  "centerChannelBg": "#36393e",
  "centerChannelColor": "#e6e6e6",
  "codeTheme": "monokai",
  "dndIndicator": "#b74b47",
  "errorTextColor": "#fd5960",
  "linkColor": "#88a7ff",
  "mentionBg": "#7289da",
  "mentionBj": "#ffffff",
  "mentionColor": "#dcddde",
  "mentionHighlightBg": "#36393e",
  "mentionHighlightLink": "#88a7ff",
  "newMessageSeparator": "#eea941",
  "onlineIndicator": "#64b285",
  "sidebarBg": "#2f3136",
  "sidebarHeaderBg": "#282b30",
  "sidebarHeaderTextColor": "#818386",
  "sidebarTeamBarBg": "#202226",
  "sidebarText": "#dbdbdb",
  "sidebarTextActiveBorder": "#35363c",
  "sidebarTextActiveColor": "#dcddde",
  "sidebarTextHoverBg": "#35363c",
  "sidebarUnreadText": "#f8f8f8"
}

Steps to reproduce

Mattermost version: 5.5.1 (63830002741) OS: macOS Sonoma 14.0

Whenever Boards are fresh opened in the app the colors are too bright. What resolves it though is saving again the same custom theme settings. And it works fine until Boards are reopened again.

Expected behavior

image

Observed behavior (that appears unintentional)

image

Guia do colaborador

Pilha de tecnologia
typescriptreact
Domain
frontend
Tipo Issue
bug
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
3
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
half day
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
stale
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
clear
Prerequisites
ReactCSS in JS or theme contextReading existing theme code
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
40
Direção de pesquisa
The issue is that when Boards is opened for the first time, the custom theme colors appear too bright, but re saving the theme fixes it. This suggests a race condition where the theme is not fully applied on initial load. Investigate the theme initialization flow in the source code, likely in files related to theme handling (e.g., `webapp/src/components/themeProvider.tsx` or similar). Look for any asynchronous loading of theme data that might cause the default colors to be used initially. Also check if there is a difference between the initial load and subsequent loads that reapply the theme correctly. The test should verify that the colors match the saved theme immediately on first open.