matomo-org/matomo

The newly added daily mail report cannot be sent on the same day！

Open

#18.378 aberto em 25 de nov. de 2021

Ver no GitHub
 (2 comments) (0 reactions) (0 assignees)PHP (21.513 stars) (2.847 forks)batch import
BugHelp wanted

Description

The newly added daily mail report cannot be sent on the same day!

Steps to Reproduce

  1. Add a new daily email report, such as 4:00 pm (current 2:00 pm)
  2. No email report will be sent at 4:00 pm on the same day
  3. Check TasksTimetable to find the task at 4:00 pm the next day

Environment

  • Matomo Version: 4.5.0
  • PHP Version: 7.4

image

Guia do colaborador

Pilha de tecnologia
None
Domain
backend
Tipo Issue
bug
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
2
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
1-3 hours
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
stale
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
clear
Prerequisites
Basic PHPUnderstanding of cron/scheduling
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
75
Direção de pesquisa
Investigate the scheduling logic in Matomo's TasksTimetable implementation. The bug is that new daily email reports are scheduled for the next day instead of the same day if added after the scheduled time. Look for a function that calculates the next run time for scheduled tasks, possibly in a file like 'core/TasksTimetable.php'. Check if there is a comparison of the current time with the scheduled time, and ensure that if the scheduled time is later in the day, the task should execute today. The fix might involve adjusting a condition or adding a check for same day scheduling when the scheduled time is after the current time.