marionettejs/backbone.marionette

Clean up tests

Open

#3.248 aberto em 2 de nov. de 2016

Ver no GitHub
 (10 comments) (0 reactions) (0 assignees)JavaScript (1.294 forks)batch import
great for beginnershelp wanted

Métricas do repositório

Stars
 (7.085 stars)
Métricas de merge de PR
 (Mesclagem média 34m) (1 fundiu PR em 30d)

Description

Looking over the tests many of them use older terms (some even Marionette v1). There are a few tests that were modified to match the current behavior, but aren't in fact testing anything anymore. And in general the tests could be updated to be cleaner and more consistent.

Further I believe most of the tests should be organized by class and then by either a feature of that class or an integration with a mixin or other class. We have too many one-off test files that it is difficult to tell where to add something.

I'll be playing with organization and style of tests while writing new ones for https://github.com/marionettejs/backbone.marionette/pull/3244 while examining what is currently there. I just want to be thinking about what improvements can be made.

Additionally there's a Readme file in the test directory that is completely irrelevant to our current setup. 😞

Guia do colaborador