mapbox/mapbox-gl-js
FeatureLevelRemove- and SourceLevelRemove-Benchmarks in remove_paint_state.js are exactly the same
Aberta
#10.049 aberto em 23 de out. de 2020
good first issue
Métricas do repositório
- Stars
- (10.532 estrelas)
- Métricas de merge de PR
- (Métricas PR pendentes)
Description
Unless I'm missing something, both benchmarks were already the same when they were added in #7761 by @peterqliu :
https://github.com/mapbox/mapbox-gl-js/blob/ff8e087b6e7cc9fe63eb4809a0895b38029a67e2/bench/benchmarks/remove_paint_state.js#L88-L100 https://github.com/mapbox/mapbox-gl-js/blob/ff8e087b6e7cc9fe63eb4809a0895b38029a67e2/bench/benchmarks/remove_paint_state.js#L102-L114
I haven't used these APIs yet, but I believe the SourceLevelRemove should have used something like this?
// No loop
this.map.removeFeatureState({source: 'land'});
Maybe also source-property level like this?
// No loop
this.map.removeFeatureState({source: 'land'}, 'bench');