llvm/llvm-project
Ver no GitHubDecomposition Declaration diagnostic for missing initializer is pretty unclear
Open
#90.107 aberto em 25 de abr. de 2024
clang:diagnosticsgood first issuequality-of-implementation
Métricas do repositório
- Stars
- (26.378 stars)
- Métricas de merge de PR
- (Mesclagem média 1d 2h) (1.000 fundiu PRs em 30d)
Description
Given the following code:
#include <utility>
std::pair<int, double> MyFunc();
void foo() {
auto [A, B] C = MyFunc();
}
Our diagnostic is just:
<source>:9:10: error: decomposition declaration '[A, B]' requires an initializer
9 | auto [A, B] C = MyFunc();
| ^
<source>:9:16: error: expected ';' at end of declaration
9 | auto [A, B] C = MyFunc();
| ^
| ;
2 errors generated.
Compiler returned: 1
https://godbolt.org/z/h9zKT5zGe
No compilers are particularly good at this diagnostic, but all the others at least highlight the C as the mistake, whereas Clang's error is pretty opaque/points at the opening bracket.
I'd prefer we move the 'arrow' to the position where the initializer is expected. Additionally, some improved diagnostic wording that highlights what went wrong better would be appreciated.