libp2p/jvm-libp2p

Test coverage of MultiplexHandler/Channel

Aberta

#27 aberto em 12 de jul. de 2019

 (2 comentários) (0 reação) (0 responsável)Kotlin (85 forks)auto 404
good first issue

Métricas do repositório

Stars
 (359 estrelas)
Métricas de merge de PR
 (Métricas PR pendentes)

Description

Cover the MultiplexHandler/Channel classes with unit tests. These are pretty central and non-primitive classes so they should be tested well. Primary attention should paid to closing child channels, so once the channel is created it must be finally closed. Child channels shouldn't leak. There are following close circumstances:

  • parent channel is closed
  • remote peer sends RESET signal
  • local peer sends RESET (on channel.close() invoked)
  • remote and local peers sends CLOSE (on channel.disconnect())

Child channels may be created with MultiplexHandler.createStream() asynchronously from any thread and prior to the parent channel is activated. Those cases should also be considered.

Guia do colaborador