leecade/react-native-swiper
Loop={true} + initialIndex leads to brief off by one error flicker
Aberta
#1.003 aberto em 30 de jun. de 2019
component: ViewPagerhelp wanted🐛bug🔎investigate
Métricas do repositório
- Stars
- (10.334 estrelas)
- Métricas de merge de PR
- (Métricas PR pendentes)
Description
Which OS ?
iOS
Version
1.6
- react-native-swiper v1.6
- react-native v0.59.8
Expected behaviour
I was debugging an issue where setting the index param briefly showed the wrong data (off by one earlier) for a brief second before a redraw happened.
In debugging, this seems to be related to the loop={true} behavior (the default), since eliminating looping causes the offset to be calculated correctly and no flicker.
I'm guessing the implementation has some kind of 'extra' item at the front to handle the left-swipe when looping, and the initialOffset is not accounting for this?
Actual behaviour
Setting index causes it to start drawing on the correct position without a flicker.
Steps to reproduce
- Create a Swiper with multiple items, and loop={true}
- Set the initial index.
- Observe that it is briefly off by one before correcting itself.