jsx-eslint/eslint-plugin-react

[jsx-key]: report on `yield`

Open

#352 aberto em 7 de dez. de 2015

Ver no GitHub
 (2 comments) (1 reaction) (0 assignees)JavaScript (2.797 forks)batch import
enhancementhelp wantedrule

Métricas do repositório

Stars
 (8.630 stars)
Métricas de merge de PR
 (Nenhuma PRs mesclada em 30d)

Description

Seems like yield <Component x={y}/> should be reported by jsx-key if there is no key prop.

This is valid:

for (let [idx, datum] of data.entries()) {
  yield (<MyComponent datum={datum} key={idx} />)
}

This is reported:

for (let [idx, datum] of data.entries()) {
  yield (<MyComponent datum={datum} />) // msg: need `key` prop
}

I can knock this out, if it makes sense.

(cc #332 as it will likely conflict with this if completed concurrently.)

Guia do colaborador