jsx-eslint/eslint-plugin-react

react/require-optimization warns when using PureRenderMixin.shouldComponentUpdate

Aberta

#1.019 aberto em 11 de jan. de 2017

 (4 comentários) (0 reação) (0 responsável)JavaScript (2.731 forks)batch import
enhancementhelp wanted

Métricas do repositório

Stars
 (9.293 estrelas)
Métricas de merge de PR
 (Métricas PR pendentes)

Description

react/require-optimization reports the following as incorrect even though it follows Facebook's documentation for using PureRenderMixin with ES6 classes (link):

export class MyComponent extends React.Component {
    constructor(props) {
        super(props);
        this.shouldComponentUpdate = PureRenderMixin.shouldComponentUpdate.bind(this);
    }
}

I can try submitting a fix if you agree that this is actually a bug

Guia do colaborador