josdejong/mathjs

Matrix sum along a dimension is defined to return a `MathScalarType`, but might return higher dimension

Aberta

#3.202 aberto em 12 de mai. de 2024

 (5 comentários) (0 reação) (1 responsável)JavaScript (1.314 forks)batch import
bughelp wantedtypescript

Métricas do repositório

Stars
 (15.065 estrelas)
Métricas de merge de PR
 (Métricas PR pendentes)

Description

Describe the bug When summing over an axis of a matrix, we always lose just one dimension. If the matrix is 2D, we'll get a 1D array. If the matrix is 3D, we'll get a 2D matrix. What happens now, is that math.sum declares that it returns a MathScalarType, instead of optionally returning a matrix.

To Reproduce

const mat = math.matrix([[1,2,3],[4,5,6]])
console.log(math.sum(mat, 0))

> DenseMatrix { _data: [ 5, 7, 9 ], _size: [ 3 ], _datatype: undefined }

Guia do colaborador