jonkemp/inline-css

Media queries inside extraCss option can't be preserved

Open

#26 aberto em 10 de fev. de 2016

Ver no GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (80 forks)github user discovery
feature requesthelp wanted

Métricas do repositório

Stars
 (440 stars)
Métricas de merge de PR
 (Métricas PR pendentes)

Description

If media query CSS is passed into the extraCss option and preserveMediaQueries is true, or if CSS is added through a <link> tag, the media query-specific CSS isn't preserved in the HTML output.

Here's a small test case.

The use case for working with applyLinkTags is using inline-css in a basic web development workflow, where you have separate HTML and CSS files, and some CSS is inside of media queries and needs to be preserved in the inlined HTML.

The use case for working with extraCss is running inline-css in the browser, where we're avoiding having to read or write from a filesystem. So instead of using <link> tag replacement, all of the CSS to be inlined is passed through extraCss.

Ideally the media query CSS in extraCss can be dropped into a <style> tag in the final output. I can think of a workaround, but it would be nice if the library could handle it.

Also an FYI, version 2 of Foundation for Emails (formerly Ink) will be using this library to inline CSS :)

Guia do colaborador