jonas-schievink/rubble

Only reply to LL_VERSION_IND once

Open

#49 aberto em 23 de abr. de 2019

Ver no GitHub
 (0 comments) (1 reaction) (0 assignees)Rust (58 forks)user submission
area: link layergood first issuestatus: needs codetype: bug

Métricas do repositório

Stars
 (403 stars)
Métricas de merge de PR
 (Nenhuma PRs mesclada em 30d)

Description

Either master or slave may send the LL_VERSION_IND LL Control PDU, and both will respond to it. According to the spec, you're supposed to keep track of whether you've already sent this and ignore the PDU in that case. We currently rely on the master to implement this correctly, since we'd otherwise end up in an endless loop.

To fix this, we need to add another bool to the real-time LinkLayer state to track whether we've sent this already. Eventually we should collapse all the bool flags into a single byte storing them as bitflags.

Guia do colaborador