jieter/django-tables2

Default value not respected on export

Aberta

#710 aberto em 30 de out. de 2019

 (1 comentário) (0 reação) (0 responsável)Python (443 forks)batch import
Help wanteddocs

Métricas do repositório

Stars
 (2.012 estrelas)
Métricas de merge de PR
 (Nenhuma PRs mesclada em 30d)

Description

I use the default value heavily in my tables, but noticed that default is not respected when I export tables.

It's the following code in django_tables2/rows.py

    def get_cell_value(self, name):
        """
        Returns the final rendered value (excluding any html) for a cell in the
        row, given the name of a column.
        """
        return self._get_and_render_with(
            self.table.columns[name], render_func=self._call_value, default=None
        )

As you can see, default=None is passed to get_and_render_with, effectively ignoring the default value.

Is there a reason for this? If there is, should we document it? Happy to contribute.

Thanks for the great library.

Guia do colaborador