jamesplease/react-request
change `fetching` to be set to `true` on mount for non-lazy requests
Aberta
#178 aberto em 25 de mai. de 2018
breakingenhancementhelp wanted
Métricas do repositório
- Stars
- (358 estrelas)
- Métricas de merge de PR
- (Nenhuma PRs mesclada em 30d)
Description
I was wondering if you'd consider a slight change for non-lazy behavior. Right now it seems like you need to do:
<Fetch url="/me">
{({ fetching, failed, data }) => {
if (fetching) return ...
if (failed) return ...
if (!data) return null
return ...
}}
</Fetch>
There's an extra case where the component has just mounted, but hasn't yet started the request where fetching == false but data == null. Apollo seems to avoid this, such that you can handle the fetching and failed cases up front, and then assume you have data after that, which just reduces a little of the boilerplate.
Would you be down for that change?