ipfs/kubo

NoAnnounce should work for /dns addresses added by AutoTLS

Open

#10.830 aberto em 6 de jun. de 2025

Ver no GitHub
 (1 comment) (0 reactions) (0 assignees)Go (13.906 stars) (2.725 forks)batch import
P2exp/intermediatehelp wantedkind/bug

Description

Checklist

  • My issue is specific & actionable.
  • I am not suggesting a protocol enhancement.
  • I have searched on the issue tracker for my issue.

Description

It seems that AutoTLS will figure out external IPs on ipv4 and ipv6 and add dns announce addresses accordingly. It does not take into account whether the IPs pointed to by these addresses are in the NoAnnounce filter.

Guia do colaborador

Pilha de tecnologia
go
Domain
backendinfrastructure
Tipo Issue
bug
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
3
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
1-3 hours
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
fresh
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
clear
Prerequisites
basic knowledge of IPFSfamiliarity with Gounderstanding of AutoTLS feature
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
30
Direção de pesquisa
Start by examining the AutoTLS implementation in the IPFS kubo repository, likely in the Go files under the 'config' or 'p2p' directories. Look for where DNS announce addresses are generated and where the NoAnnounce filter is applied. The bug is that AutoTLS does not check the NoAnnounce filter when adding announce addresses. Check the AutoTLS configuration and routing logic to see how addresses are added and ensure they respect the NoAnnounce filter.