ipfs/ipfs-desktop

Uninstall don't delete %AppData%

Open

#1.864 aberto em 25 de jun. de 2021

Ver no GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (5.632 stars) (912 forks)batch import
P2area/windowseffort/hoursgood first issuehelp wantedstatus/ready

Description

  • OS: Windows
  • Version of IPFS Desktop 0.16.0

Describe the bug The following folders are created by IPFS-Desktop while it's being used by the user:

%AppData%\Roaming\IPFS Desktop %USERPROFILE%\.ipfs %USERPROFILE%\.ipfs-desktop

None of which will be removed when IPFS-Desktop will be uninstalled.

Following the principle of the least surprise this should be the case, as this is the warn message Windows shows when uninstalling an application:

ipfs_desktop_screenshot_bugreport_no_data_cleanup_on_uninstall_uninstall_message

To Reproduce Steps to reproduce the behavior:

  1. Use IPFS Desktop
  2. Uninstall it via the Settings -> Apps
  3. Complete the uninstall procedure
  4. Look at the quoted paths, which still exist

Expected behavior All data associated with IPFS Desktop should be removed when uninstalling.

Guia do colaborador

Pilha de tecnologia
javascriptnodejselectron
Domain
desktop
Tipo Issue
bug
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
3
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
1-3 hours
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
stale
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
clear
Prerequisites
Familiarity with Electron app structureKnowledge of electron builder or NSIS installerWindows file system permissions
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
75
Direção de pesquisa
Investigate the uninstall configuration in the repository, likely in electron builder.yml or a custom NSIS script. The folders to delete are %AppData%\Roaming\IPFS Desktop, %USERPROFILE%\.ipfs, and %USERPROFILE%\.ipfs desktop. Check the existing uninstall process and add steps to remove these directories. Ensure that user data is deleted only on uninstall, not during upgrades.