influxdata/telegraf

Cancel gracefully when connecting to kafka broker

Open

#12.214 aberto em 9 de nov. de 2022

Ver no GitHub
 (1 comment) (0 reactions) (0 assignees)Go (4.161 forks)batch import
area/kafkahelp wantedsize/m

Métricas do repositório

Stars
 (9.892 stars)
Métricas de merge de PR
 (Mesclagem média 2d 12h) (136 fundiu PRs em 30d)

Description

If the user sends a signal to telegraf while kafka_consumer is connecting to the broker (before sarama.NewConsumerGroup() has returned), the signal will be delayed until connection is made or timed out. This means sigint to shut down telegraf, or sighup to reload config are ignored while connecting to the broker.

Since #12111, telegraf allows the kafka connection to be deferred until after startup and to retry for a very long time in case the broker is down. This means the time spent connecting to the broker can be much larger and signals can be blocked indefinitely.

It doesn't look like there is a way to cancel sarama.NewConsumerGroup(). We need to find out if there is a different way to connect that has a way to cancel, or work with upstream to add one.

Guia do colaborador