hound-search/hound

Keep repo filter after search

Open

#251 aberto em 24 de mai. de 2017

Ver no GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (5.470 stars) (606 forks)batch import
enhancementgood first issuehelp wanted

Description

Problem Description

Hound UI does not keep the repo filter after reload or redirect to the website

Steps to reproduce

  1. go to hound website
  2. filter for a specific repo
  3. press search
  • filter for repo is applied correctly
  1. press f5 and search again
  • filter is removed

Expected behavior

  • Repo filter is applied correctly after reload

I want to use hound search for a specific repo by linking directly to: [[https://hound.local/?repos=my-repo]]

Unfortunately after doing so the search term will again be searched over all repos.

I tried to fix it but the ui code in ui/assets/js/hound.js is too complex for me. It seems that the params are not overwritten correctly when the website is reloaded.

Regards

Guia do colaborador

Pilha de tecnologia
javascript
Domain
frontend
Tipo Issue
bug
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
3
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
half day
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
stale
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
mostly clear
Prerequisites
JavaScriptURL parameters handling
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
30
Direção de pesquisa
Investigate how the repo filter parameter is handled in `ui/assets/js/hound.js`. The issue is that the repo filter from URL query string is not persisted across page reloads. Look at how search parameters are read and applied. Check if the filter is being correctly parsed from `window.location.search` and applied to the search state. The code likely resets parameters on initialization. A fix would involve reading the 'repos' query parameter on page load and passing it to the search function.