google/leveldb

Make background thread stoppable

Open

#863 aberto em 18 de dez. de 2020

Ver no GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (39.075 stars) (8.199 forks)batch import
enhancementhelp wanted

Description

Hi,

Current version of LevelDB has detached background thread that can't be stopped and each environment calls std::abort() in destructor. This behavior prevents using of LevelDB in plugin dlls that can be started and stopped when main application still runs.

I think it is better to allow background thread to finish tasks in queue and then exit, when environment is being destroyed. That will make database loadable and unloadable.

Guia do colaborador

Pilha de tecnologia
cpp
Domain
database
Tipo Issue
feature
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
3
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
1-2 days
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
stale
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
clear
Prerequisites
C++ threadingLevelDB environment API
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
30
Direção de pesquisa
Investigate the current environment destructor and background thread implementation in LevelDB. Look at files such as util/env posix.cc and include/leveldb/env.h to understand how the background thread is created and managed. Identify where std::abort() is called and design a mechanism to allow the thread to finish its current tasks and exit gracefully when the environment is destroyed. Review any existing discussions in the issue comments for additional insights or constraints.