google/closure-compiler

require with a substitution-free template string is not recognized by process_common_js_modules

Open

#2.626 aberto em 21 de ago. de 2017

Ver no GitHub
 (4 comments) (0 reactions) (0 assignees)Java (7.176 stars) (1.197 forks)batch import
P2help wanted

Description

I'm using the compiler with the process_common_js option set to true.

The following code works fine:

/** @const */
const update = require( "./update.js" );

However, switching to a substitution-free template string breaks:

/** @const */
const update = require( `./update.js` );

resulting in:

src/main.js:8: ERROR - variable require is undeclared
const update = require( `./update.js` );
               ^^^^^^^

The code style of the project I'm working on imposes template strings wherever syntactically possible (only object keys get a pass and can use double quotes). Of course, this does include paths in require statements. Sadly, it seems the CommonJS machinery does not recognize such statements as processable.

As a workaround, I can break from the code style but it is clearly not ideal and it would be really nice if the compiler was able to handle this.

Guia do colaborador

Pilha de tecnologia
javajavascriptnodejs
Domain
tooling
Tipo Issue
bug
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
3
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
1-3 hours
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
stale
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
clear
Prerequisites
JavaScriptCommonJS modulesGoogle Closure Compiler internals
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
60
Direção de pesquisa
Examine the source code of the Closure Compiler, particularly the function `process common js modules`. The issue is that template literals (backticks) without substitutions are not recognized as valid require() arguments. Look for where the compiler parses and extracts module paths from require statements; the fix likely involves updating a regex or parser to accept template strings. Check the issue comments for any additional context. The repository is at https://github.com/google/closure compiler.