google/closure-compiler

require with a substitution-free template string is not recognized by process_common_js_modules

Aberta

#2.626 aberto em 21 de ago. de 2017

 (4 comentários) (0 reação) (0 responsável)Java (1.197 forks)batch import
P2help wanted

Métricas do repositório

Stars
 (7.176 estrelas)
Métricas de merge de PR
 (Métricas PR pendentes)

Description

I'm using the compiler with the process_common_js option set to true.

The following code works fine:

/** @const */
const update = require( "./update.js" );

However, switching to a substitution-free template string breaks:

/** @const */
const update = require( `./update.js` );

resulting in:

src/main.js:8: ERROR - variable require is undeclared
const update = require( `./update.js` );
               ^^^^^^^

The code style of the project I'm working on imposes template strings wherever syntactically possible (only object keys get a pass and can use double quotes). Of course, this does include paths in require statements. Sadly, it seems the CommonJS machinery does not recognize such statements as processable.

As a workaround, I can break from the code style but it is clearly not ideal and it would be really nice if the compiler was able to handle this.

Guia do colaborador