golang/go
x/tools/gopls: consider using &S form instead of *S for pointer type struct field autocompletion
Aberta
#39.227 aberto em 23 de mai. de 2020
NeedsDecisionToolsgoplshelp wanted
Métricas do repositório
- Stars
- (133.883 estrelas)
- Métricas de merge de PR
- (Nenhuma PRs mesclada em 30d)
Description
Currently autocompletion for a struct field uses the field's type as the placeholder text. For example,
type F struct {...}
type S struct {
Field *F
}
The autocompletion for the Field will return "newText":"Field: ${1:*F},".
gopls uses the type info for placeholder text, so I don't think the choice is incorrect nor invalid.
But if the suggestion used &F instead, it would be more convenient when users want to use composite literals. Especially, if the type name is long to type, reusing what's already in the placeholder will save many keystrokes.