felangel/bloc
refactor: stop losing the original stack trace from dart 2.16
Fechada
#2.995 aberto em 21 de nov. de 2021
examplegood first issuerefactor
Métricas do repositório
- Stars
- (12.452 estrelas)
- Métricas de merge de PR
- (Mesclagem média 2d 22h) (5 fundiu PRs em 30d)
Description
You must stop losing the original source stack trace like this (just for example):
it's big trouble, to read exceptions without source stacktraces, especially in crashlytics or sentry like logs
from dart 2.16 you must use Error.throwWithStackTrace like this:
//@dart=2.16
...
} on FirebaseAuthException catch (e, stackTrace) {
Error.throwWithStackTrace(
SignUpWithEmailAndPasswordFailure.fromCode(e.code),
stackTrace,
);
}
also, instead:
} catch (_) {
you must write:
} on Object {
or:
} on Object catch (error, stackTrace) {