facebookexperimental/Recoil

useRecoilCallback batched set calls update state incorrectly

Open

#1.935 aberto em 5 de ago. de 2022

Ver no GitHub
 (14 comments) (0 reactions) (0 assignees)JavaScript (19.428 stars) (1.151 forks)batch import
bughelp wanted

Description

We've been using Recoil quite extensively and believe we have encountered a bug with useRecoilCallback and state updating.

There is a rootState atom that we want to update via a useRecoilCallback that contains multiple set calls. If the set calls within useRecoilCallback try to set the recoil state of rootState directly or through a single selector layer, the final rootState is as expected. However, if there is more than one layer of selector dependencies, it is only the last set that has a result on rootState.

Here is the CodeSandbox.

Expected: All steps change their state from ['1', '2', '3'] to ['one', 'two', 'three'] Result: The only step changing the state is the last one for which set has run. In effect: ['1', '2', '3'] changes to ['1', '2', 'three']

Guia do colaborador

Pilha de tecnologia
javascripttypescriptreact
Domain
frontend
Tipo Issue
bug
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
4
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
1-2 days
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
active
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
clear
Prerequisites
React basicsRecoil fundamentalsSelector dependencies
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
25
Direção de pesquisa
Examine the implementation of useRecoilCallback in the Recoil source code, specifically how batched set calls are handled. Investigate how selector dependency layers affect state updates. Check if there are any existing tests or related issues that discuss transaction batching. Consider whether the issue is in the selector cache invalidation logic.