facebook/TestSlide

Fix TestCase loading with nested classes

Open

#51 aberto em 27 de set. de 2019

Ver no GitHub
 (0 comments) (0 reactions) (0 assignees)Python (58 forks)auto 404
Python Unittestbughelp wanted

Métricas do repositório

Stars
 (147 stars)
Métricas de merge de PR
 (Métricas PR pendentes)

Description

TestSlide loads TestCase classes using this logic. Upstream Python, does it like this. This means, that If the module has this:

class Outer:
  class Inner(TestCase):
    def test_something(self):
      pass

Python won't consider Inner.test_something as part of the test, but TestSlide will.

This can be easily fixed by refactoring the logic at TestSlide's side to match Python's, however, it won't cover other cases such as load_tests().

The proper fix for this, is to use Python's TestLoader in the same fashion as Python unittent does form its CLI.

Guia do colaborador