quiche: client re-connect upon INVALID_VERSION
#8.479 aberto em 3 de out. de 2019
Métricas do repositório
- Stars
- (27.997 stars)
- Métricas de merge de PR
- (Mesclagem média 8d) (378 fundiu PRs em 30d)
Description
A quic client session does version negotiation with server at the very beginning of the connection. But the connection doesn't re-try connect if server doesn't support the version this client session is created with, instead, it close the connection with INVALID_VERSION error and retain the advertised version list sent back by server. QuicSpdyClientSession::CryptoConnect() fails in such case. Its owner should pick a mutually supported version and try to connect thru another quic session.
In Envoy, connection creation is outside of client codec creation during with crypto handshake is done. This align with the logic described above. But currently, there is no retry upon the failure in integration test framework or any other production or toy client.
We need to add such re-try to support quic client connection failure upon INVALID_VERSION.