admin: making a streaming version of /config_dump
#32.054 aberto em 25 de jan. de 2024
Métricas do repositório
- Stars
- (27.997 stars)
- Métricas de merge de PR
- (Mesclagem média 8d) (378 fundiu PRs em 30d)
Description
/config_dump can produce a remarkably huge response. This will need to be fully buffered both as a protobuf message and an in-memory continuous string. For large configs, this will be slow and may exert memory pressure as well.
See also #31755 as well as prior work streaming admin stats in https://github.com/envoyproxy/envoy/pull/19693. This work is not trivial and has risks. See also the difficult attempt to make /stats/prometheus stream as well: https://github.com/envoyproxy/envoy/pull/24998 which needed to be rolled back due to complexities in the Prom format that made streaming difficult. See also https://github.com/envoyproxy/envoy/pull/28988 which adds a streaming json serializer, which probably should be used for this, rather than creating a protobuf structure and then serializing that.