envoyproxy/envoy

beginner: add coverage

Open

#1.963 aberto em 28 de out. de 2017

Ver no GitHub
 (10 comments) (0 reactions) (0 assignees)C++ (5.373 forks)batch import
beginnerhelp wantedtech debt

Métricas do repositório

Stars
 (27.997 stars)
Métricas de merge de PR
 (Mesclagem média 8d) (378 fundiu PRs em 30d)

Description

Going to leave open a persistent beginner ticket for adding coverage: https://s3.amazonaws.com/lyft-envoy/coverage/report-master/coverage.html

There are always a few missing things here and there especially regarding random error handling. If you are a beginner this is a great way to learn and do something valuable.

Rough steps:

  • Look at the coverage report and find something (often a single line) that looks like it should be covered.
  • Find the relevant unit test that should cover it (often in the test tree with the same file name)
  • Write the test
  • Confirm in PR coverage build that line is covered. (Coverage report is posted as a build artifact).

Guia do colaborador