Add optional error message field to DiscoveryResponse
#18.887 aberto em 3 de nov. de 2021
Métricas do repositório
- Stars
- (27.997 stars)
- Métricas de merge de PR
- (Mesclagem média 8d) (378 fundiu PRs em 30d)
Description
Title: Add optional error message field to DiscoveryResponse
Description: Engineers at Square are allowed to configure their envoy's behavior through certain key/value pairs that we add to the bootstrap node metadata. Occasionally, they submit incorrect values. They may use incorrect key names or they may use sets of configuration options that are logically incorrect. We could try to identify these errors through some process that runs alongside the Envoy sidecar, but then we'd need to update that (i.e. update our fleet of envoys) every time we wanted to expose a new configuration option.
Instead, I'd like to propose that we allow adding an error message to a DiscoveryResponse. If set, Envoy will log the error message to stdout when it receives the DiscoveryResponse. This will allow our engineers to see why their sidecar is failing to become ready. My team can then try and return actionable feedback that empowers these engineers to correct their configuration mistake!
Let me know if this is reasonable or if there is another way to accomplish what I am trying to do.