Métricas do repositório
- Stars
- (27.997 stars)
- Métricas de merge de PR
- (Mesclagem média 8d) (378 fundiu PRs em 30d)
Description
The current exporter
double bucket = supported_buckets[i];
uint64_t value = computed_buckets[i];
...
output.append(fmt::format("{0}_bucket{{{1}le=\"{2:.32g}\"}} {3}\n", prefixed_tag_extracted_name,
hist_tags, bucket, value));
outputs the bucket name without consideration for the units. However Prometheus has strong conventions for metrics which require the metric to be in base units. That is a time metric should have values comprised of seconds, not milliseconds or microseconds.
This is important as it allows timeseries operations between metrics from disparate sources without normalisation transformations scattered all over the place.
Prometheus should be normalising the sum and le fields for Microseconds and Milliseconds unit histograms into Seconds on output in the Prometheus exporter (and I think I read that the GRPC exporter is a separate codepath, so there too).
Repro steps:
Request a prometheus stats page from Envoy, and an internal stats page from a microservice, and try to compare time statistics between them.
I recognise that there are backwards compatibility considerations here, so perhaps an opt-out to allow organisations without other datasources and a strong investment solely in Envoy metrics would be a good idea.