electerious/ackee-lighthouse
Add .env property to allow to set more Browser flags
Aberta
#10 aberto em 23 de jul. de 2021
help wanted
Métricas do repositório
- Stars
- (16 estrelas)
- Métricas de merge de PR
- (Nenhuma PRs mesclada em 30d)
Description
I used the tool locally and I missed the following feature to set a custom browser path:
const createReports = async (endpoint, headers, events, urls, audit) => {
const additionalBrowserFlags = {};
if (process.env.BROWSER_PATH)
additionalBrowserFlags['chromePath'] = process.env.BROWSER_PATH;
const browser = await chromeLauncher.launch({
chromeFlags: ['--headless'],
...additionalBrowserFlags,
});
...
}
.env file:
...
BROWSER_PATH=C:\\Program Files (x86)\\Microsoft\\Edge\\Application\\msedge.exe
...
A such configuration would allow to test with multiple Chromium based browser like in my case Edge. What do you think? Would that be a proper enhancement?