eclipse-jdt/eclipse.jdt.core

Follow up on minimal target change to 1.8

Open

#2.761 aberto em 25 de jul. de 2024

Ver no GitHub
 (0 comments) (1 reaction) (0 assignees)Java (183 forks)auto 404
compilerhelp wanted

Métricas do repositório

Stars
 (233 stars)
Métricas de merge de PR
 (Métricas PR pendentes)

Description

Open TODO's from https://github.com/eclipse-jdt/eclipse.jdt.core/pull/2551

Created issues:

Following questions wait for answering by others:

  • [Stephan] Should this.currentProject.setOption(JavaCore.COMPILER_PB_RAW_TYPE_REFERENCE, JavaCore.IGNORE); be used in ConverterTestSetup.setUpJavaProject(String, String) ?
  • [Stephan]: change on BatchCompilerTest.testBridgeMethodRetention This change probably conflicts with the purpose of this test, @srikanth-sankaran ?
  • [Stephan] Change in ASTConverterTestAST8_2.test0612() caught me by surprise so I investigated:
    • the test implies to test AST at JLS8
    • using source from project Converter, Converter15, however, selects the AST level from the project. @srikanth-sankaran , @jarthana does it make any sense have such tests here? Shouldn't tests always sit in a test class corresponding to the used Converter* project, e.g., ASTConverterAST3Test?

Guia do colaborador