dynamoose/dynamoose

[FEATURE] Prevent unfilled out PRs from being merged

Open

#1.274 aberto em 21 de set. de 2021

Ver no GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2.025 stars) (349 forks)batch import
good first issuestatus:todotype:enhancement

Description

Summary:

In https://github.com/dynamoose/dynamoose/pull/1141 this was a breaking change that was not marked as so. We should prevent merging PRs unless the Breaking change question is filled out properly (ie. not answered, multiple answers filled out, Not sure answered).

Other:

  • I have read through the Dynamoose documentation before posting this issue
  • I have searched through the GitHub issues (including closed issues) and pull requests to ensure this feature has not already been suggested before
  • I have filled out all fields above
  • I am running the latest version of Dynamoose

Guia do colaborador

Pilha de tecnologia
javascriptnodejs
Domain
ci cddeveloper experience
Tipo Issue
feature
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
3
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
1-2 days
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
stale
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
clear
Prerequisites
GitHub ActionsYAML
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
60
Direção de pesquisa
Review the current PR template in the repository (likely .github/pull request template.md) and the linked PR #1141 to understand the problem. Investigate how to enforce required fields using GitHub Actions or a bot. Consider using a simple Action that parses the PR body and checks that the 'Breaking change' field is answered properly. Look at existing examples in the GitHub Marketplace or other open source projects for reference.