dotnet/aspnetcore

UrlHelperExtensions.ActionLink docs are misleading regarding requiring protocol and host

Fechada

#42.949 aberto em 27 de jul. de 2022

 (2 comentários) (1 reação) (0 responsável)C# (10.653 forks)batch import
Docsarea-routinghelp wanted

Métricas do repositório

Stars
 (37.933 estrelas)
Métricas de merge de PR
 (Mesclagem média 16d 9h) (258 fundiu PRs em 30d)

Description

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

the docs state

Generates an absolute URL if the protocol and host are non-null. See the remarks section for important security information.

but if you omit passing values or pass null it still generates an absolute URL, seeming based on the host header a request scheme of the request from http context https://github.com/dotnet/aspnetcore/blob/main/src/Mvc/Mvc.Core/src/UrlHelperExtensions.cs#L575

Expected Behavior

expect docs to not indicate absolute url requires thsoe params to be not null, should mention where it gets those values from if they are omitted or passed as null

Steps To Reproduce

n/a

Exceptions (if any)

n/a

.NET Version

6

Anything else?

No response

Guia do colaborador