decentralized-identity/ion
Ver no GitHubBitcoinClient should check for if the 'bitcoinWalletOrImportString' parameter is undefined
Open
#314 aberto em 20 de abr. de 2020
good first issue
Métricas do repositório
- Stars
- (1.219 stars)
- Métricas de merge de PR
- (Nenhuma PRs mesclada em 30d)
Description
If the admin forgets to add in either the import string or an actual IBitcoinWallet on this parameter then we should throw here. Currently, the this.bitcoinWallet member stays undefined and we throw when we try to use it.
Suggestion:
if (typeof bitcoinWalletOrImportString === 'undefined') { // throw }
// OR
// After all the initializations
if (this.bitcoinWallet === undefined) { // throw }