dareid/chakram

Invalid validation keywords and types

Open

#27 aberto em 26 de nov. de 2015

Ver no GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (907 stars) (100 forks)batch import
enhancementhelp wanted

Description

    it("should list all avilable players", function () {
        var responseStructure = {
            type: "array",
            properties:{
                enabled : {type:"string"},  //This is expected to be an integer, but test passes
                defaultLanguage :{type:"integer"},
                defaultCurrency :{type:"integer"},
                lastname :{type:"string"},
                firstname:{type:"string"},
                passwordSalt:{type:"string"},
                password:{type:"string"},
                email:{type:"string"},
                id:{type:"string"} //Also this, expected to be an integer, but it passes the test
            }
        }
        var response = chakram.get(endpoint);
        return expect(response).to.have.schema(playerDataStructure);

I observed that the properties are not checked even when the properties expected doesn't match the types in the reponse, the test still passes.

Guia do colaborador

Pilha de tecnologia
javascript
Domain
testing
Tipo Issue
bug
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
2
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
1-3 hours
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
stale
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
mostly clear
Prerequisites
Understanding of JSON schema validationFamiliarity with chakram's test structure
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
40
Direção de pesquisa
Investigate the schema validation logic in chakram's source code, likely in `lib/schema.js` or similar. The issue describes that properties are not being validated against their types. Look for where `type` and `properties` are checked, and ensure that the validator correctly enforces type constraints. Also check the existing test suite for schema validation to see if there are tests that pass incorrectly. The issue is old (2015), so the code may have changed; verify if the bug still exists in the current version.