dOrgTech/DAOcreator
`initStateStore` - Don't Assume LocalStorage
Aberta
#243 aberto em 17 de nov. de 2019
Libcode improvementgood first issuemed pri
Métricas do repositório
- Stars
- (34 estrelas)
- Métricas de merge de PR
- (Métricas PR pendentes)
Description
Currently we've hard-coded our state persistence into the UI layer and are using the localStorage of the browser. We should instead be making API calls into the Lib layer, and using an interface the implementer of the library supplies upon initialization.
For example:
import { initStateStore } from "lib/state";
// localStorage in browser, file in CLI
setStateStore({
getItem: (key: string) => { ... },
setItem: (key: string, value: string) => { ... },
clearItem: (key: string) => { ... }
});
// later in the application
getSavedDAO();
saveDAO(dao);