cube-js/cube

Clickhouse: incorrect query when filtering on 'string' measure with 'equals' operator

Aberta

#7.328 aberto em 27 de out. de 2023

 (4 comentários) (0 reação) (0 responsável)Rust (1.965 forks)batch import
driver:clickhousehelp wanted

Métricas do repositório

Stars
 (19.563 estrelas)
Métricas de merge de PR
 (Métricas PR pendentes)

Description

Describe the bug Cube generates incorrect query when measure of type 'string' is used as a filter with operator 'equals'. This applies to Clickhouse driver. Despite the measure being of type 'string', the generated HAVING clause tries to compare string value to the value of toFloat64(?).

To Reproduce Steps to reproduce the behavior:

  1. Use Clickhouse driver
  2. Use the Cube schema that I provided below
  3. Run the query with a filter on 'string' measure and operator 'equals' (see attached screenshots)

Expected behavior The correct query should be generated. Cube should not use the toFloat64 function.

Screenshots image

image

Minimally reproducible Cube Schema

cube(`cubeA`, {
    
    sql: `
        select 1 as id, 100 as number
    `,

    dimensions: {
        id: {
            type: 'number',
            sql: 'id',
            primary_key: true
        },
        number: {
            type: 'number',
            sql: 'number'
        }
    },
   
    measures: {
      high_or_low: {
        type: `string`,
        sql: `CASE WHEN ${CUBE.number} > 100 THEN 'high' ELSE 'low' END`
      },
    },
  });

Version: 0.34.10

Guia do colaborador