compat-table/node-compat-table
Ver no GitHubDuplicate identifier: why should the first test pass?
Open
#87 aberto em 4 de ago. de 2023
bughelp wanted
Métricas do repositório
- Stars
- (874 stars)
- Métricas de merge de PR
- (Métricas PR pendentes)
Description
function(){
try {
eval('var d = function d([d]) { return d };if (d([true]) !== true) return false;');
} catch (e) {
return !(e instanceof SyntaxError);
}
try {
eval('var f = function f([id, id]) { return id }');
return false;
} catch (e) {
return e instanceof SyntaxError;
}
}
In the first try/catch block, it evaluates several statements with eval. One of the statements has return false; in it, which is a syntax error because the top level of code evaluated by eval isn't a function. Is this intentional?
The line seems to have changed recently in https://github.com/williamkapke/node-compat-table/commit/39a4e84b716a12273ec6c96276b460660345b742, which seems to have tried to wrap the code in an eval so that the SyntaxError can be caught and returned as false. However, in doing so, it made versions that formerly pass now fail: