cmu-delphi/forecast-eval
Data downloading fails if score type is coverage or if summarizing across multiple locations
Aberta
#255 aberto em 31 de mar. de 2023
good first issue
Métricas do repositório
- Stars
- (6 estrelas)
- Métricas de merge de PR
- (Métricas PR pendentes)
Description
We see this error
Warning: Error in filter: Problem while computing `..1 = !is.na(Score) | target_end_date >= filterDate`.
Caused by error in `mask$eval_all_filter()`:
! argument "filterDate" is missing, with no default
filterOverAllLocations requires a filterDate arg, but when totaling across locations or looking at coverage scores, we don't pass filterOverAllLocations a filterDate.
createExportScoreDataFrame will need to be passed at least a date to use in the filter. The value should be dataCreationDate to match other score-generating logic.
Consider passing input$asOf as well and adding as-of data onto the exported dataframe, to more closely match what we're using in the plots.