catchorg/Catch2

Refactor and centralize compiler detection

Aberta

#2.094 aberto em 3 de nov. de 2020

 (12 comentários) (0 reação) (0 responsável)C++ (3.228 forks)batch import
DevelopmentGood First IssueTweak request

Métricas do repositório

Stars
 (20.381 estrelas)
Métricas de merge de PR
 (Mesclagem média 1d 8h) (1 fundiu PR em 30d)

Description

Currently Catch2 detects compilers ad-hoc, at the place where the code needs to be compiler-specific. This brings a lot of trouble with more obscure compilers, because compilers like to masquerade for different compilers, such as Clang defining GCC-version macros, ICC defining both, IBM XL self-reporting as Clang, and so on. Because compiler-specific sections of code are often indeed compiler-specific, not detecting compilers properly can be a problem, e.g. Clang will complain that it found unknown pragma if we try to disable GCC-specific warning without checking that Clang is not used.

The solution is to perform more rigorous compiler detection, and centralize it, so that updates don't have to be done in multiple places.

Guia do colaborador