cake-build/cake
Ver no GitHubAutomatic argument retrieval with fallback mechanism
Open
#1.265 aberto em 10 de out. de 2016
Good first issueHelp wantedImprovementUp-for-grabs
Métricas do repositório
- Stars
- (3.742 stars)
- Métricas de merge de PR
- (Mesclagem média 1d 1h) (25 fundiu PRs em 30d)
Description
For my own purposes I have created this convenience method. It checks for argument values in the following order:
- Specified via command line
- Specified via build server (build server variable)
- Specified via environment variable
This way we need less explicit variable definitions because most of them are automatically retrieved from the build server (in most cases, people are running cake from a build server and pass in variables already defined in the build server).
It's currently written for continua ci only, but this can easily be extended to other build servers as well and renamed to GetVariable
public string GetContinuaCIVariable(string variableName, string defaultValue)
{
var argumentValue = Argument(variableName, "non-existing");
if (argumentValue != "non-existing")
{
Information("Variable '{0}' is specified via an argument", variableName);
return argumentValue;
}
if (ContinuaCI.IsRunningOnContinuaCI)
{
var buildServerVariables = ContinuaCI.Environment.Variable;
if (buildServerVariables.ContainsKey(variableName))
{
Information("Variable '{0}' is specified via Continua CI", variableName);
return buildServerVariables[variableName];
}
}
if (HasEnvironmentVariable(variableName))
{
Information("Variable '{0}' is specified via an environment variable", variableName);
return EnvironmentVariable(variableName);
}
Information("Variable '{0}' is not specified, returning default value", variableName);
return defaultValue;
}
What do you think, is it worth PR-ing?