Add a proper popup in configuration joystick menu that does not close the whole menu when the vehicle is automatically disarmed
#785 aberto em 28 de fev. de 2024
Métricas do repositório
- Stars
- (181 stars)
- Métricas de merge de PR
- (Métricas PR pendentes)
Description
Currently no alert popup is shown when the joystick configuration view is opened and vehicle is automatically disabled, we could add a Swal alert but when the user either interact with it or press ESC it will close the configuration menu itself due to it being listen to these events, so in this case we would need to change this behavior, or maybe auto close the popup
I would say that auto-closing the popup would be enough for now, but the reality is that if the popup appears, there's a high risk of the user clicking outside it to close it and (I think) that will close the config menu also, so I would say for us to do the right way and put a close button. Can you open an issue to track that for a following PR?
Originally posted by @rafaellehmkuhl in https://github.com/bluerobotics/cockpit/issues/784#issuecomment-1969227273