astral-sh/uv

Move environment variable parsing to `EnvironmentOptions`

Open

#14.720 aberto em 18 de jul. de 2025

Ver no GitHub
 (25 comments) (1 reaction) (0 assignees)Rust (84.934 stars) (3.111 forks)batch import
good first issuehelp wantedinternal

Description

In https://github.com/astral-sh/uv/pull/14662 I added a new EnvironmentOptions abstraction which allows us to express semantics that Clap cannot and perform up-front parsing of non-CLI environment variables, e.g., https://github.com/astral-sh/uv/pull/14544 and https://github.com/astral-sh/uv/pull/14369.

We should move other extraneous environment variables to be parsed there and provided through our usual settings structs.

These changes should be relatively easy. We should probably do it one variable at a time.

  • UV_HTTP_RETRIES
  • UV_COMPILE_BYTECODE_TIMEOUT
  • UV_HTTP_TIMEOUT
  • UV_REQUEST_TIMEOUT
  • HTTP_TIMEOUT
  • UV_RUN_RECURSION_DEPTH
  • UV_RUN_MAX_RECURSION_DEPTH
  • UV_CONCURRENT_DOWNLOADS
  • UV_CONCURRENT_BUILDS
  • UV_CONCURRENT_INSTALLS
  • UV_PYTHON_INSTALL_MIRROR
  • UV_PYPY_INSTALL_MIRROR
  • UV_PYTHON_DOWNLOADS_JSON_URL
  • UV_NO_GITHUB_FAST_PATH
  • UV_GITHUB_FAST_PATH_URL
  • UV_GIT_LFS
  • UV_CUDA_DRIVER_VERSION
  • UV_AMD_GPU_ARCHITECTURE
  • UV_STACK_SIZE
  • UV_LOG_CONTEXT
  • TRACING_DURATIONS_FILE
  • UV_LOCK_TIMEOUT (https://github.com/astral-sh/uv/pull/16342#discussion_r2448547512)

Guia do colaborador

Pilha de tecnologia
rust
Domain
clideveloper experiencetooling
Tipo Issue
refactor
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
2
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
1-2 days
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
active
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
clear
Prerequisites
RustEnvironment variable parsinguv codebase structure
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
65
Direção de pesquisa
Examine the `EnvironmentOptions` abstraction introduced in PR #14662. Identify where the remaining environment variables (e.g., `UV COMPILE BYTECODE TIMEOUT`, `UV RUN RECURSION DEPTH`, `UV GIT LFS`, etc.) are currently parsed in the codebase (likely in `cli.rs` or `settings.rs`). Move each variable's parsing logic into the `EnvironmentOptions` struct following the pattern used for already completed variables like `UV HTTP RETRIES`. Update the corresponding tests and ensure the change compiles and passes tests.