apache/dubbo

[CodeReview 3.0] Dubbo in spring

Open

#8.633 aberto em 29 de ago. de 2021

Ver no GitHub
 (2 comments) (0 reactions) (0 assignees)Java (26.453 forks)batch import
help wanted

Métricas do repositório

Stars
 (41.524 stars)
Métricas de merge de PR
 (Mesclagem média 7d 14h) (20 fundiu PRs em 30d)

Description

1) DubboConfigConfigurationRegistrar duplicate with DubboComponentScanRegistrar.

DubboConfigConfigurationRegistrar only has one function call:

public void registerBeanDefinitions(AnnotationMetadata importingClassMetadata, BeanDefinitionRegistry registry) {
    // initialize dubbo beans
    DubboSpringInitializer.initialize(registry);
}

but DubboComponentScanRegistrar also has this function call:

public void registerBeanDefinitions(AnnotationMetadata importingClassMetadata, BeanDefinitionRegistry registry) {
    // initialize dubbo beans
    DubboSpringInitializer.initialize(registry);

    Set<String> packagesToScan = getPackagesToScan(importingClassMetadata);

    registerServiceAnnotationPostProcessor(packagesToScan, registry);
}

Guia do colaborador