angular/components

Delayed tooltip still shown if clicked prior to matTooltipShowDelay

Fechada

#8.065 aberto em 27 de out. de 2017

Ver no GitHubGuia do colaborador
 (5 comentários) (0 reação) (0 responsável)TypeScript (6.650 forks)batch import
P3area: material/tooltiphelp wanted

Métricas do repositório

Stars
 (24.044 estrelas)
Métricas de merge de PR
 (Mesclagem média 3d 12h) (98 fundiu PRs em 30d)

Description

Bug, feature request, or proposal:

Bug: Delayed tooltip is still shown if element is clicked prior to matTooltipShowDelay

What is the expected behavior?

A delayed tooltip should not be shown if element is clicked prior to the matTooltipShowDelay time being reached.

What is the current behavior?

A tooltip with matTooltipShowDelay set to a positive value will be displayed even if the element is clicked before the delay time is reached. A click after the delay time is reached and the tooltip is shown will correctly hide the tooltip.

For at least a button element, when the element does not have focus and mouseenter and click occur prior to matTooltipShowDelay, the tooltip is correctly not shown. However, if the element has focus prior to these events, the tooltip is incorrectly shown even after a click.

What are the steps to reproduce?

http://plnkr.co/edit/qfWnfq0pxHRS0hJKMSRZ

What is the use-case or motivation for changing an existing behavior?

Tooltips that are still displayed after click can sometimes obscure underlying elements.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular 4.4.6 Material 2.0.0-beta.12-0ea4370 Windows 10 Chrome 61.0.3163.100 Typescript 2.5.3

Is there anything else we should know?

Guia do colaborador

Direção de pesquisa
The bug occurs when an element has focus, then mouseenter and click happen before the show delay timer completes, causing the tooltip to appear. The fix involves ensuring that the show timer is cancelled when a click event occurs before the delay. The tooltip directive source is in src/lib/tooltip/tooltip.ts. Focus on the show() and hide() methods and how they handle blur and click events. The provided plunkr reproduces the issue. No linked PRs or assignees, so it's available for contribution.
Pilha de tecnologia
typescript
Domain
frontend
Tipo Issue
Bug
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
2
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
1-3 horas
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
Antigo
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
Claro
Prerequisites
Angular MaterialTypeScript
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
70