angular-ui/ui-grid
Ver no GitHub[selection] - event rowSelectionChanged - pass GridCol along with GridRow
Open
#4.534 aberto em 16 de out. de 2015
breakinghelp wantedtype: enhancement
Métricas do repositório
- Stars
- (5.395 stars)
- Métricas de merge de PR
- (Nenhuma PRs mesclada em 30d)
Description
currently event rowSelectionChanged has the following signature:
on.rowSelectionChanged($scope, function (row, event) { ... })
I have a use case when I'd also find useful information about column being clicked.
Detailed scenario:
Clicking on the row has an event associated (ex: redirects to another state). However, the very last column of each row is a custom column that allows deleting of that row. Currently clicking on the delete button in the given row will also trigger rowSelectionChanged event, which is not desired just for that column.
Given that I had information about GridCol in this event, I could write something like:
on.rowSelectionChanged($scope, function(row, col, event) {
if (col.name != 'delete') {
$state.go('superState');
}
});
This would be a breaking change since it would change the signature of the event. If I'm given a green light, I'll submit a PR.