akxcv/vuera

Distribution file compatibility

Open

#29 aberto em 22 de fev. de 2018

Ver no GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (4.260 stars) (264 forks)batch import
good first issuehelp wanted

Description

This issue came up because of IE11, but I totally understand if including support for IE11 is not something within the scope of this library. It looks like es2015 compatibility is desired based on the .babelrc:

https://github.com/akxcv/vuera/blob/30ab626d8105ed8b2223ca2aa45495daa112529a/.babelrc#L6

However, both Object.assign and Object.entries appear in the built common js file:

https://github.com/akxcv/vuera/blob/30ab626d8105ed8b2223ca2aa45495daa112529a/dist/vuera.cjs.js#L229

https://github.com/akxcv/vuera/blob/30ab626d8105ed8b2223ca2aa45495daa112529a/dist/vuera.cjs.js#L451

I always forget which level Object.assigns is at, but I believe Object.entries is much more recent? Is this maybe a bug in the rollup or babel configuration during the build?

Thanks!

Guia do colaborador

Pilha de tecnologia
javascriptreactvue
Domain
frontend
Tipo Issue
bug
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
3
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
1-3 hours
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
stale
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
mostly clear
Prerequisites
understanding of ES5/ES6 featuresfamiliarity with Babel configuration
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
30
Direção de pesquisa
Investigate the .babelrc file at line 6 to see the target environment configuration. Check the rollup config to understand how the dist files are built. Determine if Object.assign and Object.entries need to be polyfilled or if the build targets should be adjusted to avoid these modern methods.