akka/akka-http
Exception in failed CompletionStage is always wrapped in CompletionException
Aberta
#1.267 aberto em 5 de jul. de 2017
1 - triagedhelp wantedt:javat:routingt:server
Métricas do repositório
- Stars
- (1.311 estrelas)
- Métricas de merge de PR
- (Mesclagem média 1d 10h) (2 fundiu PRs em 30d)
Description
When using the completeOKWithFutureString or completeOKWithFuture directives from the javadsl, the exception in a failed CompletionStage is always wrapped in a CompletionException.
This is unfortunate, as you end up writing ExceptionHandlers like this:
ExceptionHandler exceptionHandler = ExceptionHandler.newBuilder()
.match(CompletionException.class, e -> {
if (e.getCause() instanceof IllegalStateException) return complete(StatusCodes.NOT_FOUND);
// Etc.
else return complete(StatusCodes.INTERNAL_SERVER_ERROR);
})
.build();
The CompletionException doesn't appear to contain any useful information (not in the stacktrace either), perhaps we should consider unwrapping it in akka-http - though that would be a breaking change. Perhaps we could deprecate completeOKWithFuture(String) and add completeOKWithCompletionStage(String) that unwraps, as that's the native terminology anyway?