POSYDON-code/POSYDON
IFinterpolator: Core-collapse of secondary star
Aberta
#346 aberto em 28 de jun. de 2024
enhancementgood first issuehelp wanted
Métricas do repositório
- Stars
- (42 estrelas)
- Métricas de merge de PR
- (Métricas PR pendentes)
Description
The IF interpolator for core-collapse (CC) quantities is only trained for the collapse of the primary.
While it's rare that the secondary will explode first, we do not train any IF interpolators for such situations. These binaries might fail or do the collapse calculation using core masses or the NN. (which might mean properties will be missing).
Furthermore, we should investigate that these rare events are correctly considered in the final S1/S2_state classifier and the IF interpolator values.
No clear direction for this, but an important check if one wants to talk about mass ratio reversal in the HMS-HMS grid or more unique formation channels.